Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set prune_after on a per output base #233

Open
maurerle opened this issue Apr 4, 2024 · 1 comment
Open

Option to set prune_after on a per output base #233

maurerle opened this issue Apr 4, 2024 · 1 comment
Assignees

Comments

@maurerle
Copy link
Contributor

maurerle commented Apr 4, 2024

Proposal

We would not like to prune the whole state.json but only old nodes from the output (e.g. meshviewer.json) - currently, I can only set prune_after on the state.json settings, but not per output.

It would be handy to have it per output, so that one can still see, that a node was seen before 30 days, even if it was offline for more than 14 days in between.

Alternatives

An alternative approach would be to increase prune_after to 90d in the yanic.conf and add the option to only show younger nodes than 7d on the map in meshviewer.json.
Currently, meshviewer shows all nodes and does only limit maxAge for the new Node and old Nodes view.
This could be adjusted, so that meshviewer does not show nodes which are longer offline than maxAge

@genofire
Copy link
Member

genofire commented Jun 16, 2024

The Idea is good, I will take it on the roadmap.

But I did not like the name prune_after. Because it associate to easy with deletion (but the data are still there instate). So maybe maxAge, before-filter or so are better naming.

@genofire genofire self-assigned this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants