Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Subtitles/CC and 4k tag #917

Closed
tiwarys opened this issue Jan 9, 2021 · 8 comments · Fixed by #5119
Closed

Display Subtitles/CC and 4k tag #917

tiwarys opened this issue Jan 9, 2021 · 8 comments · Fixed by #5119
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tiwarys
Copy link

tiwarys commented Jan 9, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
I think it would be nice if you add a tag Subtitles/CC if a video has them like YouTube website does.

Describe the solution you'd like to see implemented
Display Subtitles/CC tag if a video has them.

Describe alternatives you've considered
YouTube website displays Subtitles tag.

Screenshots
YouTube Subtitles

@tiwarys tiwarys added the enhancement New feature or request label Jan 9, 2021
@GilgusMaximus
Copy link
Contributor

Hi, so this should be rather easy to implement. I'd suggest adding the 4k label as well because these 2 fields are both provided by the ytdl-core module and are next to each other.

@GilgusMaximus GilgusMaximus added the good first issue Good for newcomers label Jan 16, 2021
@tiwarys
Copy link
Author

tiwarys commented Jan 16, 2021

I'd suggest adding the 4k label as well

Shall I open another issue for 4k label?

@GilgusMaximus
Copy link
Contributor

All good. I'm just gonna change the title and add 4k as well. A new issue for this is not really necessary.
Thanks for asking tho :)

@GilgusMaximus GilgusMaximus changed the title Display Subtitles/CC tag Display Subtitles/CC and 4k tag Jan 17, 2021
@saideepesh000
Copy link
Contributor

@PrestonN @GilgusMaximus, I'm working on it.

@dkshxd
Copy link
Contributor

dkshxd commented May 16, 2024

Happy to work on this one

@GreatGreenStar
Copy link

Although it would likely be opened in a second issue if at all, maybe in the future integration with live-caption on supported devices could be done to allow (attempted) captions for all videos, even those without YouTube auto-generated captions?

dkshxd added a commit to dkshxd/FreeTube that referenced this issue May 17, 2024
@dkshxd
Copy link
Contributor

dkshxd commented May 17, 2024

I've added a comment on the "Live" label in the pull request. Shouldn't be too difficult to implement, however will leave to different ticket.

Don't know about the look of the "Live" label as it seems to have an icon left of it. It'll be easier to ditch the icon and use a "text dot" instead.

@absidue
Copy link
Member

absidue commented May 20, 2024

@GreatGreenStar

Although it would likely be opened in a second issue if at all, maybe in the future integration with live-caption on supported devices could be done to allow (attempted) captions for all videos, even those without YouTube auto-generated captions?

Your comment is unrelated to this feature request and if I'm understanding you correctly not something we would be able to do. A quick internet search for "live captions" gave me two separate things:

  1. Google Chrome's proprietary and closed source "Live Captions" feature. Due to that being closed source and proprietary, nobody other than Google can include that functionality inside their program. As FreeTube is developed by a few volunteers in their spare time and not Google, we have no way of adding that feature from Google Chrome.
  2. Microsoft Windows' "Live Captions" accessibility feature. As that's something provided by the operating system in a separate program and window, we have no control over that, so you would need to manually turn on the functionality in Windows' settings and manually move the Live Captions window to a suitable position.

FreeTubeBot pushed a commit that referenced this issue May 30, 2024
* #917 - Display Subtitles/CC and 4k tag

* Display Subtitles/CC and 4k tag - Implement themes

* Review comment changes - 4k and subtitle implementation

* Changes for review comments

* Implementation of "Live" label

* Back out duplication of "Live" label

* Changes based on code review
@FreeTubeBot FreeTubeBot removed this from To assign in Feature Requests May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants