Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Help module to show What's this is broken #13788

Closed
2 tasks done
wwmayer opened this issue May 2, 2024 · 4 comments · Fixed by #13812
Closed
2 tasks done

Using the Help module to show What's this is broken #13788

wwmayer opened this issue May 2, 2024 · 4 comments · Fixed by #13812
Assignees
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD

Comments

@wwmayer
Copy link
Contributor

wwmayer commented May 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Use the command Std_WhatThis and click on any active command. No Help window is opened but an error is raised that WebGui isn't an existing module.

Full version info

OS: Ubuntu 22.04.4 LTS (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37085 (Git)
Build type: debug
Branch: main
Hash: c7c07f28c639e82a6d2c58f4aaef5b42cddcc83c
Python 3.10.12, Qt 5.15.3, Coin 4.0.0, Vtk 7.1.1, OCC 7.5.1
Locale: German/Germany (de_DE)

Subproject(s) affected?

Core

Anything else?

By default the Help module should use the system browser to show the documentation.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 2, 2024

on windows it opens the default browser

@wwmayer
Copy link
Contributor Author

wwmayer commented May 2, 2024

The behaviour depends on user settings:

if FreeCAD.GuiUp:

By default the system browser isn't used.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 2, 2024

so the solution would be to remove the setting and use the OS browser?

@maxwxyz maxwxyz added Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD labels May 2, 2024
@yorikvanhavre
Copy link
Member

The webGui is still used as a fallback:

WebGui.openBrowserHTML(html, baseurl, title, ICON)

I'll fix that to use the desktop browser instead.

@yorikvanhavre yorikvanhavre self-assigned this May 2, 2024
yorikvanhavre added a commit to yorikvanhavre/FreeCAD that referenced this issue May 3, 2024
sliptonic pushed a commit that referenced this issue May 6, 2024
* Help: Removes use of WebGui - fixes #13788

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
adrianinsaval pushed a commit to Ondsel-Development/FreeCAD that referenced this issue May 6, 2024
* Help: Removes use of WebGui - fixes FreeCAD#13788

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants