[Bug]No rules on who should merge a PR #10201
WandererFan
started this conversation in
Discussions that will turn in to issues but need refining
Replies: 2 comments
-
Do you have an idea for how to codify who should merge PRs when the primary developer is absent? We obviously don't want to encode actual developer names into the process document, but we don't have a "sub-developer" or "assistant developer" position, at least not formally. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I don't have a solution in mind. This was more of a plea to start a discussion. If the Maintainer is to be a guarantor of the quality of a PR, then I don't see any good solution other than adding headcount. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Is there an existing issue for this?
Forums discussion
https://www.forum.freecadweb.org/viewtopic.php?p=638190#p638190
Version
0.21 (Development)
Full version info
Subproject(s) affected?
Project Tools & Websites
Issue description
There are 8 active "core developers" with merge rights (Maintainers in the terminology of CONTRIBUTING.md) to the main FreeCAD source repository.
There are currently no guidelines on which Maintainer should merge which PRs.
Historically, the primary Maintainer for a given workbench has handled all PRs related to that workbench.
If the primary Maintainer is otherwise occupied or there is no primary Maintainer for a given workbench, PRs may languish in the queue for extended periods.
a) The contribution policy should be revised to provide guidance on who should merge which PRs.
b) Consideration should be given to increasing the size of the Maintainer pool.
Anything else?
No response
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions