-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding materials seems to be broken in latest dev! #312
Comments
Hello @MisterMakerNL , |
So, some news: What happens: Render WB is based on FreeCAD's materials management system, that's been a design choice since the beginning. The problem is that this system is being completely overhauled in version 0.22, and some recent developments have changed the behavior of some material objects we use. |
Take your time, with the amount of tiny bugs the overlay system has brought it's going to take a while until 0.22 gets released! |
Guys, they've completely changed the materials management system in version 0.22 (what a mess)! So, after half a day reading their code, I made a partial fix #318: it avoids the error message and the material can be created. However the underlying material values are not imported yet: still a lot of work to be done. |
Indeed... @davesrocketshop could you give some assistance here? |
It is in fact not completely changed. It is in mid change so it may get worse before it gets better. I would not expect render to work with 0.22 at this point as there's a lot of work still to be done. For background on what's being done, see I will be able to help with this but it is premature at this point. Let the dev version stabilize a bit first. |
Hold off on fixing this for 2 reasons:
This is a good test case. Once I get my current PR merged I'll be in a better position to help. |
Still broken. |
1 similar comment
Still broken. |
An update since I know people have been waiting on this for a while. There has been a lot of progress made in the migration to v0.22.
To some degree coding can't progress until those items are merged, but I will be doing as much as possible until then. We're now at the mercy of the merge process. |
Hello David, |
Do you anticipate any changes to the property models, or is it too early to ask this question? |
No change in the property model! I've just found a way to download materials from big web sites like https://matlib.gpuopen.com or https://ambientcg.com/ and to convert them to our internal format (Disney shader), thanks to MaterialX library (https://materialx.org/). This gives access to hundreds of PBR materials with just a few clicks!!! |
Hello @davesrocketshop, |
I get following error message:
If I add the material in 0.21 everything works fine in dev version.
The text was updated successfully, but these errors were encountered: