Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on Reply All #2299

Open
CodeMouse92 opened this issue Mar 4, 2021 · 3 comments
Open

Warn on Reply All #2299

CodeMouse92 opened this issue Mar 4, 2021 · 3 comments

Comments

@CodeMouse92
Copy link
Contributor

Objective

Warn on Reply All if...

  1. No recipients have been added/removed from the To or CC fields,
  2. The default behavior is not Reply All; we don't want to nag on the normal workflow.
  3. There's more than one recipient in To and CC combined.

Testing Notes

Ensure that the warning appears just before sending only if the Reply All recipients are in the To and CC fields, with no additions or removals.

Tips

I've started this already in the branch codemouse92/replyallwarn, but I'm running into a roadblock trying to get the message being replied to so I can call participantsReplyAll on it again. Insight appreciated, @bengotow!

References

https://community.getmailspring.com/t/reply-all-popups-before-replying-to-multiple-people/912

@Phylu
Copy link
Contributor

Phylu commented Mar 7, 2021

Could you try to get the original message by searching in the thread identified by this._draft.threadId for the message where originalMessage.headerMessageId === this._draft.replyToHeaderMessageId?

@CodeMouse92
Copy link
Contributor Author

That's what I was thinking. I'll have to try that later. I was going cross-eyed trying to find the function for locating the thread or message. Do you know where that is?

@Phylu
Copy link
Contributor

Phylu commented Mar 13, 2021

Unfortunately, I was not able to figure it out. Probably a hint from @bengotow is really needed here. I would also be interested in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants