Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSR regression #321

Open
jpdriver opened this issue May 12, 2022 · 2 comments · May be fixed by #322
Open

Fix SSR regression #321

jpdriver opened this issue May 12, 2022 · 2 comments · May be fixed by #322
Assignees
@rilakumma

Comments

@jpdriver
Copy link
Contributor

we need to refactor <LiveProvider /> to avoid relying on useEffect (which does not run on the server because it only runs after each render)

we also have a useState hook that gets initialized with empty values. The refactor should make transpileAsync() callable in both the useEffect hook and the useState initializer.
@jpdriver jpdriver mentioned this issue May 16, 2022
Open
@tujoworker
Copy link

Thanks for reporting. I'll come with an PR.

@tujoworker tujoworker linked a pull request May 25, 2022 that will close this issue
Open
@tujoworker
Copy link

@jpdriver and @rilakumma Are you able to look at the PR?

@tujoworker tujoworker mentioned this issue May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rilakumma rilakumma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(SSR): add support for initial SSR render tujoworker/react-live
3 participants
@tujoworker @jpdriver @rilakumma