Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of rails secrets raises deprecation warnings on Rails 7.1+ #648

Open
dvkch opened this issue Feb 7, 2024 · 2 comments
Open

Usage of rails secrets raises deprecation warnings on Rails 7.1+ #648

dvkch opened this issue Feb 7, 2024 · 2 comments

Comments

@dvkch
Copy link

dvkch commented Feb 7, 2024

Hi there,

I am currently in the process of migrating a Rails app to Rails 7.1, and I found that Forest's usage of Rails.application.secrets usage in boostrapper.rb raises a deprecation warning/exception (depending on your configuration).

This check seems to have been there for 2 years now, would it be possible to remove it ? Or at least check only if ForestLiana.application_url hasn't already been set before.

For reference, here is the offending line:

if Rails.application.secrets.forest_application_url

Thank you for considering :)

@matthv
Copy link
Member

matthv commented Feb 8, 2024

Hi @dvkch , thanks for your feedback

I have just created a ticket on our end to remove this warning.
I will let you know when it's processed.

@dvkch
Copy link
Author

dvkch commented Feb 8, 2024

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants