-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The LianaOption "expressParentApp" is not described in the library's types #1084
Comments
I just check and you are right. We export type through a public repository Definitely Typed |
Hi @Thenkei ! I'm perfectly ok with opening a P.R. for this. However, the types I see in my code base are the ones from this repository (this file) so doing a P.R. on DefinitelyTyped would not fix my issue. I'm a bit surprised that you are maintaining the types (with some differences) there and in this repository. Any reason for that? To me, as long as you have the types in the main repository, it's useless to have the DefinitelyTyped ones. I can also open a P.R. on both repositories if you think I should. Thanks for your answers anyway! |
Expected behavior
I would like to be able to set the
expressParentApp
option when I call theinit
function without TypeScript telling me:Object literal may only specify known properties, and 'expressParentApp' does not exist in type 'LianaOptions'.
Actual behavior
TypeScript tells me:
Object literal may only specify known properties, and 'expressParentApp' does not exist in type 'LianaOptions'.
Failure Logs
N/A
Context
TODO: Please provide any relevant information about your setup.
The text was updated successfully, but these errors were encountered: