Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character and word level tokenizers #24

Open
darsnack opened this issue Apr 2, 2021 · 3 comments
Open

Add character and word level tokenizers #24

darsnack opened this issue Apr 2, 2021 · 3 comments
Labels
enhancement New feature or request gsoc-proposal Good issues to tackle for GSoC proposals

Comments

@darsnack
Copy link
Member

darsnack commented Apr 2, 2021

Add simple character and word level tokenizers that conform to the LearnBase.jl getobs/nobs interfaces.

@darsnack darsnack added enhancement New feature or request good first issue Good for newcomers gsoc-proposal Good issues to tackle for GSoC proposals help wanted Contributions welcome! labels Apr 2, 2021
@AriMKatz
Copy link

AriMKatz commented Apr 5, 2021

Ref: https://github.com/JuliaText/WordTokenizers.jl

@samuelzxu
Copy link
Contributor

Just a few questions. By this conformity do you mean another method for getobs,nobs functions treating a tokenized type? Since the tokenizer as the reference describes is essentially splitting text by spaces or simply into individual characters, would this would be used in the context of preprocessing text-based datasets? Would the new module and tests go into /src/methods and /test/methods respectively?

Also, how do I self-assign this issue?

@darsnack
Copy link
Member Author

darsnack commented Apr 6, 2021

No need to self-assign the issue. Just submit a PR when ready.

By conform, I mean defining a new getobs/nobs on the tokenizer type to call the underlying splitting methods. The functions should go in src/datasets/transformations.jl.

@lorenzoh lorenzoh removed help wanted Contributions welcome! good first issue Good for newcomers labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gsoc-proposal Good issues to tackle for GSoC proposals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants