Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Rename IsActuallyPlayingSth to IsActuallyPlaying #2565

Open
xxSeys1 opened this issue May 7, 2024 · 1 comment
Open

[Proposal] Rename IsActuallyPlayingSth to IsActuallyPlaying #2565

xxSeys1 opened this issue May 7, 2024 · 1 comment
Labels
audio scripting suggestion Idea or improvement suggestion
Milestone

Comments

@xxSeys1
Copy link

xxSeys1 commented May 7, 2024

Issue description:

The Sth is just weird in a programming context and IsActuallyPlaying tells the user equally as well/ bad what the method is doing.

This breaks the api and also is just a visual thing, so I'd add this in 2.0 or with a new audio system if Flax gets one.

Steps to reproduce:

none

Minimal reproduction project:

none

Flax version:

1.8.1

@mafiesto4 mafiesto4 added audio suggestion Idea or improvement suggestion scripting labels May 7, 2024
@mafiesto4 mafiesto4 added this to the 1.9 milestone May 7, 2024
@mafiesto4
Copy link
Member

Good idea to rename it (let's keep old name as deprecated until removal in 2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio scripting suggestion Idea or improvement suggestion
Projects
None yet
Development

No branches or pull requests

2 participants