Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency dio produces errors dio version >= 4.0.4 fails with "Future already completed" #45

Open
jdde opened this issue Nov 30, 2022 · 2 comments
Open

Dependency dio produces errors dio version >= 4.0.4 fails with "Future already completed" #45

jdde opened this issue Nov 30, 2022 · 2 comments

Comments

@jdde
Copy link
Contributor

jdde commented Nov 30, 2022

Hi guys, I just tried to see if the new dio v4.0.6 resolved the issue mentioned in your documentation https://docs.flagsmith.com/clients/flutter#known-issues
"If using the package Dio, you may encounter an error saying Bad state: Future already completed. There is a bug in the Dio package, introduced in 4.0.5 (and as of writing this on 12/09/2022, is unresolved). To resolve, you'll need to pin your Dio version in pubspec.yaml to 4.0.4 or earlier."

Unfortunately this is not the case.

I'll attach my test results as screenshots.
I reproduced it easily, by just locking the dio version in the sdk itself & in the example application.
Then start it for web - see if the error occurs.

Here you can see the result with different version - 4.0.4, 4.0.5, 4.0.6

Web state with dio 4.0.4
dio_4_0_4

Web state with dio 4.0.5
dio_4_0_5

Web state with upgrading dio to 4.0.6
dio_4_0_6
jdde added a commit to jdde/flagsmith-flutter-client that referenced this issue Nov 30, 2022
@jdde
- locked dio version, to make sure flagsmith is compatible to dio
326c870 
- see Flagsmith#45
@jdde
Copy link
Contributor Author

jdde commented Nov 30, 2022

@dabeeeenster just mentioned this dio issue in discord: cfug/dio#1550
worth to link it in here

dabeeeenster pushed a commit that referenced this issue Nov 30, 2022
@jdde
Bugfix/lock dio version use working version in example (#46)
02d8fbf 
* - locked dio version, to make sure flagsmith is compatible to dio
- see #45

* - re-executed "flutter pub get" to not use the non-working version 4.0.6 in the example - the example throws errors.
@dabeeeenster
Copy link
Collaborator

@matthewelwell can we close this issue on account of #48 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dabeeeenster @jdde