add CommonName to generated certificates #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @FiloSottile , just wondering if you've had a chance to take a look at this pull request? I think it's good to go, but let me know if there's anything else that needs to be done. Thanks! |
|
@elexx I actually went ahead and built from source on Windows to add this pull request. I also have a Synology Disk Station and although it handled the cert imports fine on mine, I just liked having the CN label to easily differentiate between my different certs. Thanks for this! And @FiloSottile, thank you for this awesome tool. I use it all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CN to the subject makes generated certificates usable in DSM (Synology).
I created a certificate, uploaded it to my DSM and are able to use it for example as "System default" certificate. Also DSM now shows a "Issued to:" value:
Without this patch, "Issued to:" was empty and the certificate was not selectable for any usages.
Fixes #469