Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken final link when clicking on a Twitter link "t.co" #733

Closed
Olfdev opened this issue Sep 30, 2022 · 2 comments
Closed

Broken final link when clicking on a Twitter link "t.co" #733

Olfdev opened this issue Sep 30, 2022 · 2 comments
Labels
Broken-bypass A bypass is misbehaving or no-longer working

Comments

@Olfdev
Copy link

Olfdev commented Sep 30, 2022

Domain

t.co

Link

https://t.co/1v2xnVfF8d?ref_src=twsrc%5Etfw%7Ctwcamp%5Eembeddedtimeline%7Ctwterm%5Escreen-name%3Abeepboxco%7Ctwcon%5Es1_c14

Version

0.0.0

What browsers are you seeing the problem on?

Chrome

What OS are you seeing the problem on?

Windows

Anything else?

Hello,

There is an issue when FastForward is ON with t.co links.
As an example, you can click on some beepbox.co links in the embedded twitter window and the link created is "doubled" leading in a non working link.

Here is a diff between without (left) and with (right) FastForward.
hbdLO9

Repro:

  1. Activate FastForward
  2. Go to beepbox.co
  3. Click on a beepbox link in the embedded twitter window that uses t.co
  4. Observe the black window
  5. Disable FastForward
  6. Click again on the link
  7. Observe the working window
  8. Do the diff between both links
  9. Observe the "doubled" link when FastForward is ON
@Olfdev Olfdev added the Broken-bypass A bypass is misbehaving or no-longer working label Sep 30, 2022
@Olfdev Olfdev changed the title Broken final link when clicking on a Twitter link via beepbox.co Broken final link when clicking on a Twitter link "t.co" Sep 30, 2022
@lostdusty
Copy link
Contributor

See #784.

@lostdusty lostdusty closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2022
@Murazaki
Copy link

Murazaki commented Mar 3, 2023

Not sure I get how this works, but t.co <a> tags actually contains the complete link, separated by useless span tags. Why not try something like this ?

hrefBypass("t.co", () => {
	ifElement("a", a => {
	    const realLink = a.innerHTML.replace(/<.*?>/, '');
		safelyNavigate(realLink)
	}, () => {
	})
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Broken-bypass A bypass is misbehaving or no-longer working
Projects
None yet
Development

No branches or pull requests

3 participants