Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting the last entry in the view/edit history #750

Open
AVBL opened this issue Nov 12, 2023 · 5 comments
Open

deleting the last entry in the view/edit history #750

AVBL opened this issue Nov 12, 2023 · 5 comments
Labels

Comments

@AVBL
Copy link

AVBL commented Nov 12, 2023

Far Manager version

3.0.6111.0

OS version

10

Other software

No response

Steps to reproduce

  1. Press Alt-F11 to open History.
  2. Move cursor to last entry.
  3. Delete it (Shift-Del).

Expected behavior

The cursor should move to the entry that was the penultimate one before.

Actual behavior

The cursor flies to the very beginning of the story, to the first entry.

PS: As far as I remember, this did not happen before, but I cannot say at what point this change occurred. Perhaps at the same time when the redrawing of history was "optimized" (with the preservation of dividing lines with dates under which there are no records left after their deleting).

@AVBL AVBL added the bug label Nov 12, 2023
@yegor-mialyk
Copy link
Contributor

It does not happen and works as expected until you reach the point with a date separator. If a date separator is the last item on the list then deleting the pre-last ("non-date") item will force a cursor to jump to the first element.

MKadaner added a commit to MKadaner/FarManager that referenced this issue Nov 26, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Nov 27, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Nov 27, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Nov 27, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Nov 29, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Dec 5, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Dec 6, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Dec 6, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Dec 7, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Dec 7, 2023
MKadaner added a commit to MKadaner/FarManager that referenced this issue Dec 7, 2023
alabuzhev added a commit that referenced this issue Dec 7, 2023
gh-750: Fixed `VMenu` set selection behavior around list edges.
@MKadaner
Copy link
Contributor

Fixed in 6223.

@AVBL
Copy link
Author

AVBL commented Dec 19, 2023

  1. Решил проверить, обнаружил странную фишку. Удаляю все записи под чертой с датой, черта остаётся, курсор перескакивает на последний файл над чертой. Логично. (Вариант, когда удаляются записи за несколько дней и остаются несколько черт, не проверял). Далее магия. Нажимаю стрелку вниз, курсор уходит в самое начало списка (логично, хотя немного неожиданно, поскольку визуально в конце списка есть ещё черта), но возвращаясь в конец вижу, что последняя черта пропала. Спрашивается, почему нельзя было удалить черту сразу, как только удаляется последняя запись, относящаяся к ней?

PS: Это не претензия, просто обратил внимание на мелкую визуальную несуразность.

@MKadaner
Copy link
Contributor

Preexisting issue. In the previous versions, after the last item below the last separator is removed, the selection jumps to the top (the issue addressed here). If you press the up arrow, the selection wraps over to the bottom of the list and the separator is there. If you press the down arrow, the selection wraps over to the top and the last separator goes out of the viewport, but pressing the up arrow again reveals it is still there. Now you can be wrapping over the edge of the list by pressing up and down arrows multiple times, and the last separator stays in place. However, if you press the end key at the top of the list, the separator disappears.

I think this behavior should be addressed separately. If you feel like this, please file another bug report.

@AVBL
Copy link
Author

AVBL commented Dec 20, 2023

This oddity is not so great, besides, everyone already knows about it, so I probably won't waste time and effort on it.

After all, all the oddities with empty lines appeared even when the display of history was "optimized". I still didn't understand what exactly was optimized and how, and why it was done by creating new problems, but my report #638 about the set of empty lines that will remain after deleting entries in the history has already been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants