Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad page size check #7

Open
sbarisic opened this issue Aug 22, 2018 · 0 comments
Open

Bad page size check #7

sbarisic opened this issue Aug 22, 2018 · 0 comments

Comments

@sbarisic
Copy link

sbarisic commented Aug 22, 2018 •
edited

https://github.com/FICTURE7/unicorn-net/blob/master/src/Unicorn.Net/Memory.cs#L101
https://github.com/FICTURE7/unicorn-net/blob/master/src/Unicorn.Net/Memory.cs#L103
https://github.com/FICTURE7/unicorn-net/blob/master/src/Unicorn.Net/Memory.cs#L128
https://github.com/FICTURE7/unicorn-net/blob/master/src/Unicorn.Net/Memory.cs#L130

Page alignment checks are wrong, they should be:

if ((address & ((ulong)PageSize - 1)) != 0)

Same for size.
supremestdoggo added a commit to supremestdoggo/unicorn-net that referenced this issue Dec 14, 2021
@supremestdoggo
Fix page size check
d1e234c 
This PR is meant to solve Issue FICTURE7#7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbarisic