Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ufcx.h #687

Open
garth-wells opened this issue Apr 26, 2024 · 3 comments
Open

Remove ufcx.h #687

garth-wells opened this issue Apr 26, 2024 · 3 comments
Labels
proposal Proposed change
Milestone

Comments

@garth-wells
Copy link
Member

With the removal of finite elements and dofmaps from UFCx in #681, there isn't much left apart from the kernel interface. Maybe we can removed ufcx.h and simply document the interface?

@garth-wells garth-wells added the proposal Proposed change label Apr 26, 2024
@garth-wells garth-wells added this to the v0.9.0 milestone May 1, 2024
@jhale
Copy link
Member

jhale commented May 2, 2024

I'm currently trying to make ufcx.h and subsequent cffi compilation C11 compliant (complex number support is optional). So if it was removed that would simplify things a lot.

@jhale
Copy link
Member

jhale commented May 2, 2024

Here is the branch to make ufcx.h C11 compatible (in the sense that complex number support is optional) https://github.com/FEniCS/ffcx/blob/jhale/c11compliance/ffcx/codegeneration/ufcx.h

But then CFFI complains because it cannot deal with C preprocessor macros.

@jhale
Copy link
Member

jhale commented May 2, 2024

Any remaining necessary metadata about a form/expression could be written to a flat file format rather than being packaged up in a c-struct. This would also have the advantage of being easier to use the metadata across languages - the consumer would only have to worry about a single C interface for the kernel calls.

Edit: Downside is that it would be harder to consume this metadata in C-like languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposed change
Projects
None yet
Development

No branches or pull requests

2 participants