-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExaBGP restart & reload race condition #1172
Comments
Thank you for reporting this issue, I will try to look into it soon. |
I am not sure why you are referencing SIGUSR1, is it not SIGHUP being sent when reload is used? Systemd may send a SIGHUP for reload which may lead to a stop of ExaBGP. I believe I ended up not using SIGHUP for reload as it can be sent by terminals to indicate that it was closed. We are going back to 2009 when I made these decisions: systemd did not exist yet and standards were not as clear as now. Systemd should issue a SIGTERM on "stop" (and "restart"). and then restart the program when the program terminates. Perhaps the systemd file should be changed?
|
Hello ExaBGP Team,
Firstly, I'd like to express my appreciation for your exceptional product.
We utilize Ansible for installing and configuring ExaBGP in our setups. Below is our Ansible 'exabgp' role:
And here's the handler 'Reload ExaBGP':
Unfortunately, we've noticed an issue. Our monitoring system detected that 'exabgp.service' was restarted: "Systemd's exabgp.service restarted 1 times on node1."
This issue can be reproduced using the 'systemctl restart exabgp && systemctl reload exabgp' command. On my Ubuntu 22.04, the result is as follows:
The journal log provides this information:
From the logs, the issue arises because exabgp doesn't have sufficient time to start before systemd sends 'USR1'.
To address this, we applied the workaround by overriding the default exabgp unit:
We'd appreciate you letting us know if there's a better solution.
To Reproduce
Steps to reproduce the behavior:
systemctl restart exabgp && systemctl reload exabgp
Expected behavior
Reload command sent immediately after restarting the service doesn't lead to failing and restarting the service a second time.
Environment:
The text was updated successfully, but these errors were encountered: