Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw Signhost Exception on 429 #56

Open
WouterJanson opened this issue Nov 24, 2020 · 0 comments · May be fixed by #57
Open

Throw Signhost Exception on 429 #56

WouterJanson opened this issue Nov 24, 2020 · 0 comments · May be fixed by #57
Labels
bug

Comments

@WouterJanson
Copy link
Contributor

A 429 response doesn't contain JSON, so people get the following error:
Unexpected character encountered while parsing value: T. Path '', line 0, position 0.
This happens for example when too many bad requests are made.

We should throw a proper SignhostException.
@WouterJanson WouterJanson linked a pull request Nov 25, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature - Fix non-json error handling WouterJanson/SignhostClientLibrary
1 participant
@WouterJanson