Examine access levels for all sample types

[yo1995]

Currently some types aren't correctly limited to the least access level. An example

arcgis-maps-sdk-swift-samples/Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift

Line 227 in 05b3a37

class GeometryEditorMenuModel: ObservableObject {

The data model type can be private, but is internal right now. In a very rare case, a type might be reused by another sample, which causes inconvenience to fix.

We can go through each sample and make them correct.