Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Resolve the Task introduced retain cycle #387

Merged
merged 7 commits into from
Apr 18, 2024
Merged

[Fix] Resolve the Task introduced retain cycle #387

merged 7 commits into from
Apr 18, 2024

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Apr 15, 2024

Description

This PR fixes the retain cycle discussed in #153 .

Linked Issue(s)

How To Test

use deinit to see if the model is deallocated after sample is closed.

deinit {
    print("✅ cleared")
}

@yo1995 yo1995 self-assigned this Apr 15, 2024
@yo1995 yo1995 requested review from philium, a team and dfeinzimer and removed request for a team April 16, 2024 18:41
@yo1995 yo1995 marked this pull request as ready for review April 16, 2024 18:41
@yo1995 yo1995 linked an issue Apr 16, 2024 that may be closed by this pull request
Examine potential retain cycle from unstructured Task blocks #153
Open
@yo1995 yo1995 requested a review from philium April 16, 2024 20:43
philium
philium reviewed Apr 16, 2024
View reviewed changes
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift Outdated Show resolved Hide resolved
@philium philium mentioned this pull request Apr 18, 2024
Merged
@yo1995
Copy link
Collaborator Author

yo1995 commented Apr 18, 2024 •
edited

Thank you! I'll retrofit the other sample with some comments from this PR.

@yo1995 yo1995 merged commit 9d0d938 into v.next Apr 18, 2024
1 check passed
@yo1995 yo1995 deleted the Ting/Fix-153 branch April 18, 2024 20:36
@yo1995 yo1995 mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philium philium philium approved these changes

@dfeinzimer dfeinzimer dfeinzimer approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examine potential retain cycle from unstructured Task blocks
3 participants
@yo1995 @philium @dfeinzimer