Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Script execution leaks pipe FDs #408

Open
mbethke opened this issue Mar 26, 2024 · 1 comment
Open

[Bug] Script execution leaks pipe FDs #408

mbethke opened this issue Mar 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mbethke
Copy link

mbethke commented Mar 26, 2024

This bug just started turning on my system (Arch Linux, Sway 1.9-1, swaync 0.10.1-1): after about 9 days of uptime, every notification is accompanied by an error message saying

Failed to run script: example-script
Output: Too many open files

Swaync's /proc/$PID/fd directory currently shows 1018 open files, 1002 of which are pipes.

My Vala-fu is weak, but my suspicion of execute_command in src/functions.vala is still strong ;) It looks like std_output isn't being closed if something goes wrong between spawning the process and setting up the child watch, although I can't think of too many things that could. As notoriously fiddly as this spawning stuff is especially in a portable way, I wouldn't be surprised if it was a GTK/Vala bug either.

Here's my config in case it helps.

@mbethke mbethke added the bug Something isn't working label Mar 26, 2024
@ErikReider
Copy link
Owner

ErikReider commented Apr 15, 2024

Are you running the latest version? This was fixed in #388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants