Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Korean localization #2034

Open
12 of 13 tasks
ErikEJ opened this issue Dec 8, 2023 · 23 comments · Fixed by #2138
Open
12 of 13 tasks

[Feature] Add Korean localization #2034

ErikEJ opened this issue Dec 8, 2023 · 23 comments · Fixed by #2138
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@ErikEJ
Copy link
Owner

ErikEJ commented Dec 8, 2023 •
edited

Languages or language updates:

  • Korean
  • Japanese
  • Polish (in progress)
  • Russian
  • French updates
  • Italian updates
  • Turkish updates
  • Czech
  • German
  • Zh hant
  • Portugese (Brazil)
  • Zh Hans updates
  • Spanish updates

Guide:

  • Fork and clone the repo
  • Open in VS 2022
  • Open the /src/GUI/EFCorePowerTools.sln file
  • Open the EFCorePowerTools project
  • In the Locales folder, copy each *.en.resx file to your language, f.ex. *.de.resx
  • Translate the strings in the newly created files (maybe install the extension to understand context)
  • In the root folder copy VSpackage.en.resx to your language, f.ex. VSpackage.de.resx and translate
  • In the root folder, copy EFCorePowerToolsPackage.en.vsct to your language, f.ex. EFCorePowerToolsPackage.de.vsct and translate all <ButtonText> entries
  • Create a Pull Request with your changes!

Any contributor gets 1 hour of free consultancy!

List of supported languages
@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 8, 2023

@rasputino @sm15455 @Varorbc @sinankeskin @omatrot

Would be very grateful if you could have another look at the state of your translations - I have added a number of texts in English to your localized files (or they are missing completely)

It concerns the .resx files in the Locales folder, the EFCorePowerToolsPackage.xx.vsct file and VSPackage.xx.resx files in the root project folder.

@omatrot A EFCorePowerToolsPackage.fr.vsct file for context menu translations is missing from your side.

Thanks for all your help!

@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 8, 2023

latest daily build should fix missing context menu translations for all lanuages.

@sinankeskin
Copy link
Contributor

Unfortunately I'm not in the .NET world anymore. Thanks for the great effort 🙏

rasputino added a commit to rasputino/EFCorePowerTools that referenced this issue Dec 8, 2023
@rasputino
Refresh Spanish localization ErikEJ#2034
d517323
@rasputino rasputino mentioned this issue Dec 8, 2023
Merged
ErikEJ pushed a commit that referenced this issue Dec 8, 2023
@rasputino
Refresh Spanish localization #2034 (#2035)
bbf0563 
* Fixes #1848. Duplicate semicolons in dbcontext file

* Refresh Spanish localization #2034

---------

Co-authored-by: Pablo León <[email protected]>
@ErikEJ ErikEJ added enhancement New feature or request up-for-grabs labels Dec 9, 2023
Varorbc added a commit to Varorbc/EFCorePowerTools that referenced this issue Dec 10, 2023
@Varorbc
Refresh Chinese localization ErikEJ#2034
3639118
ErikEJ pushed a commit that referenced this issue Dec 10, 2023
@Varorbc
Refresh Chinese localization #2034 (#2036)
ba81ac6
@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 10, 2023

@rasputino Do you do an compare on the .resx files ? - @Varorbc did find some updates...

@paulowirth
Copy link

Do you still need a Brazilian Portuguese contributor?

@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 10, 2023

@paulowirth Someone else has said yes already, will let you know if he meant it..

@paulowirth
Copy link

@paulowirth Someone else has said yes already, will let you know if he meant it..

Sure thing. Just let me know.

@doggy8088 doggy8088 mentioned this issue Dec 10, 2023
Closed
@doggy8088
Copy link
Contributor

doggy8088 commented Dec 10, 2023 •
edited

I contributed zh-Hant translation. #2037

@rasputino
Copy link
Contributor

@rasputino Do you do an compare on the .resx files ? - @Varorbc did find some updates...

Yes, I did. I checked the git history of all .resx and .vsct files from the original pull request. And I checked it again with ResX Resource Manager.

image

ErikEJ pushed a commit that referenced this issue Dec 11, 2023
@RecursosOnline
Refresh localization #2034 (#2039)
3e84ee6 
* Added Brazilian Portuguese (pt-br)

* Revert "Added Brazilian Portuguese (pt-br)"

This reverts commit b1c723e.

* Added Brazilian Portuguese (pt-br)
@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 11, 2023

@paulowirth Someone else did pt-BR!

@paulowirth
Copy link

@paulowirth Someone else did pt-BR!

Thank you for letting me know. Cheers.

@diegomodolo
Copy link

Do you still need a Brazilian Portuguese contributor?

I will do it, but I'll let you know if I need help. Thanks!

@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 11, 2023

@diegomodolo it has been done already, as you can see from the list above

@diegomodolo
Copy link

I thought it was marked because we've talked on twitter about I doing it, but thanks for letting me know.

@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 11, 2023

@diegomodolo I think of the list as a TO DO list...

@hayriozler
Copy link
Contributor

I'll start Turkish translation

@ErikEJ
Copy link
Owner Author

ErikEJ commented Dec 17, 2023

@hayriozler Keep in mind, that it "just" needs an update, adding missing translations. (Compare the en-us files with the current tr files)

@hayriozler
Copy link
Contributor

@hayriozler Keep in mind, that it "just" needs an update, adding missing translations. (Compare the en-us files with the current tr files)

I've seen that @sinankeskin has already added the Turkish support. I'll check it, if something is missing or needs to be updated, I will create a PR.

@agriffard agriffard mentioned this issue Jan 31, 2024
Merged
@AlexRadch
Copy link
Contributor

I'll start the Russian translation

@ChaosEngine
Copy link
Contributor

I'll try to help with Polish localization.

@AlexRadch AlexRadch mentioned this issue Feb 1, 2024
Merged
@ErikEJ ErikEJ changed the title Refresh localization Add localization (Polish, Korean, Japanese) Feb 1, 2024
@AndrewKeepCoding AndrewKeepCoding mentioned this issue Feb 2, 2024
Merged
@AndrewKeepCoding
Copy link
Contributor

The Japanese localization is ready.

@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 2, 2024

@AndrewKeepCoding ありがとう - awesome

@ErikEJ ErikEJ changed the title Add localization (Polish, Korean, Japanese) Add localization (Polish, Korean) Feb 2, 2024
ChaosEngine added a commit to ChaosEngine/EFCorePowerTools that referenced this issue Feb 3, 2024
@ChaosEngine
Polish translation for ErikEJ#2034 issue
2bbe99d
@ChaosEngine ChaosEngine mentioned this issue Feb 3, 2024
Merged
@ErikEJ ErikEJ changed the title Add localization (Polish, Korean) Add Korean localization Feb 3, 2024
ChaosEngine added a commit to ChaosEngine/EFCorePowerTools that referenced this issue Feb 3, 2024
@ChaosEngine
Polish translation for ErikEJ#2034 issue
7356940
ErikEJ added a commit that referenced this issue Feb 3, 2024
@ChaosEngine @agriffard
@jscarle @AlexRadch @ErikEJ @AndrewKeepCoding
Polish translation (#2138)
365e2ab 
* Polish translation for #2034 issue

* French localizations (#2133)

* French localizations

* vsct

* Updated french translations. (#2135)

* Russian localization (#2134)

* Russian Translation 4 files

* Locales folder Translated

* EFCorePowerTools.csproj

* EFCorePowerTools.csproj

* EFCorePowerToolsPackage.ru.vsct

* small cleanup

* Update action version

* Add Japanese localization (#2137)

* fix build - jp.vsct not included yet

---------

Co-authored-by: Antoine Griffard <[email protected]>
Co-authored-by: Jean-Sebastien Carle <[email protected]>
Co-authored-by: Alexander Radchenko <[email protected]>
Co-authored-by: Erik Ejlskov Jensen <[email protected]>
Co-authored-by: Andrew KeepCoding <[email protected]>
@ErikEJ ErikEJ reopened this Feb 3, 2024
@ErikEJ
Copy link
Owner Author

ErikEJ commented Feb 6, 2024

Thanks everyone for their help with this - we are down to one missing language now.

@ErikEJ ErikEJ changed the title Add Korean localization [Feature] Add Korean localization Feb 8, 2024
@ErikEJ ErikEJ added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polish translation ChaosEngine/EFCorePowerTools
10 participants
@doggy8088 @ChaosEngine @sinankeskin @rasputino @hayriozler @ErikEJ @AlexRadch @diegomodolo @AndrewKeepCoding @paulowirth