Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Ordering of songs in a playlist #459

Open
ebadi opened this issue Oct 16, 2016 · 9 comments
Open

Feature request : Ordering of songs in a playlist #459

ebadi opened this issue Oct 16, 2016 · 9 comments
Assignees
Milestone

Comments

@ebadi
Copy link

ebadi commented Oct 16, 2016

Feature requests

  • Songs are added to the end of a playlist which is not usually desirable. No shuffle feature is also available.
  • It is easier to choose the search engine when we enter a term in the search box rather than set it in the "setting menu".

drop down menu

What is your Kaku version ?

1.7.0

What is your OS with version number ?

Ubuntu 14.04

@EragonJ
Copy link
Owner

EragonJ commented Oct 17, 2016

  1. shuffle mode is done and will be there in 1.8.0
  2. still have no time to work on drag & drop to re-position your tracks, need to work on it later.
  3. i like your suggestion for changing platform, can give it a try.

@japko36
Copy link

japko36 commented Feb 25, 2018

Hello
I'm newbie in programming, so I am asking for your understanding.
About 2 pts. If there is ordering of the playlist, I decided to add a few lines of code to temporarily solve this problem. What I propose is only the equivalent of the drag and drop feature. I added two functions in the contextual playlist menu: "Move track up" and "Move track down". Like I said before, it's just a temporary substitute for the drag and drop function. Besides, I need some help because the function I added did not work well when I try to move PlayingTrack. Maybe someone could point out my mistake.
Moving tracks function

What is your Kaku version ?

1.9.0
What is your OS with version number ?

openSUSE Leap 42.3

@EragonJ
Copy link
Owner

EragonJ commented Feb 26, 2018

@japko36 the ultimate solution is still to provide drag & drop solution here, can you lint your codes first to make sure it fits the current coding style? it's hard to understand your code by reading it :/

@japko36
Copy link

japko36 commented Feb 26, 2018

I have a request, when you find a moment, could you explain something about linting, because here there is nothing written on how to do it? I mistakenly thought that compilation was enough :( sorry

@EragonJ
Copy link
Owner

EragonJ commented Feb 27, 2018

well, it should be the same coding style or something to make sure written codes are in the same format. Right now, at least make the indentation the same as the other parts, right now your codes are not aligned and are not in the same order which is hard for me to check. Hope this clarified your thought.

BTW, the reason why the wiki for that part is not ready yet is that it should be like an automatic process that will help us do this part when committing codes. I just don't have time to do that.

@japko36
Copy link

japko36 commented Feb 27, 2018

I did what I could with the style of the code. I hope that it was more or less about it and you read it a bit better.

@japko36
Copy link

japko36 commented Mar 25, 2018

Hello again.
What do you think about the React DnD library. I just made some changes in three files to build a drag and drop function for sorting songs in a playlist. I have removed previously introduced changes in the context menu. The three files I mentioned were:
Kaku-1.9.0 / src / views / modules / Player.js,
Kaku-1.9.0 / src / views / components / shared / tracks.js,
Kaku-1.9.0 / src / views / components / shared / track / track.js.
You also need to create a file:
  Kaku-1.9.0 / src / views / components / shared / track / ItemTypes.js .
And this drag and drop function works.

@EragonJ
Copy link
Owner

EragonJ commented Mar 26, 2018

@japko36 interesting, any code for that ?

@japko36
Copy link

japko36 commented Mar 26, 2018

As I mentioned above, I made changes in these three files to implement the drag and drop feature with React DnD (licensed as MIT):
Player.js
tracks.js
track.js
and created file:
ItemTypes.js
Of course, my solution is not perfect and it probably requires corrections, but it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants