New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot handle redirect events from GitHub #293
Labels
Comments
Similar concerns have been arose other extensions's maintain as well |
EnixCoda
added a commit
that referenced
this issue
Jul 10, 2023
Applied a temporary fix via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recently, Gitako start to have unexpected behavior. And I'm afraid I might not fix them.
Gitako relies on
turbo:*
events to detect GitHub page redirect and update its own UI.But recently GitHub started to deprecate
turbo:*
events. In the GitHub's legacy UI mode,turbo:*
events are not dispatched todocument
anymore, thus Gitako's script cannot listen to them.Although the
turbo:*
events are still exposed in GitHub's global navigation mode. Gitako still not work well as expected. Because GitHub has integrated react to render the updated part after navigation. So when theturbo:*
event is patched, the DOM elements are not ready yet. And I've found no way to know when that is ready.There still exist technique to workaround those problem but that will cost much more time and not reliable.
I'm glad to see GitHub start try to provide better UX, like supporting native file tree, folding code, etc, which used to be provided by GitHub extensions. And then Gitako could retire. But GitHub might need to be more patient, at least until its feature has been implemented well enough, at least as good as the extensions'.
The text was updated successfully, but these errors were encountered: