Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issue/question: Trailing spaces in Config file parameter make CLN fail to start #7132

Open
BTCBellyButton opened this issue Mar 7, 2024 · 9 comments · May be fixed by #7251
Open

Minor issue/question: Trailing spaces in Config file parameter make CLN fail to start #7132

BTCBellyButton opened this issue Mar 7, 2024 · 9 comments · May be fixed by #7251
Labels
good first issue good for onboarding

Comments

@BTCBellyButton
Copy link

Issue

I recently updated my config file and there were a couple of trailing spaces at the end of the line that I didn't notice.
I didn't need the changes right away so I didn't restart CLN after modifying the config file.
Today I finally had to restart CLN service and it kept failing. I did change Bitcoin to Bitcoin Knots and I thought that could be the reason and it took me awhile before realizing that the problem wasn't Knots but the change I made to the config file few weeks ago...
When I finally decided to try and run it form the CLI instead than through systemctl I saw this message and I could fixed the issue:

lightningd: Config file /mnt/md0/C-Lightning/config line 24: autoclean-failedforwards-age=1296000 : '1296000 ' is not a number

So the question/proposal is:
wouldn't be better to try and remove any trailing spaces from the parameters when reading the configuration file? Or at least have some warnings showing up in the systemctl status output (if it is even possible) other than a generic failure?

image
@vincenzopalazzo
Copy link
Collaborator

looks like the value 1296000 is dirty and core lightning is taking it as a string, do you have any white space after the 1296000?

@BTCBellyButton
Copy link
Author

looks like the value 1296000 is dirty and core lightning is taking it as a string, do you have any white space after the 1296000?

Yes that's what happened and why I was proposing an improvement:

So the question/proposal is:
wouldn't be better to try and remove any trailing spaces from the parameters when reading the configuration file? Or at least have some warnings showing up in the systemctl status output (if it is even possible) other than a generic failure?

@vincenzopalazzo
Copy link
Collaborator

Sorry miss you suggestion, could be a good option IMHO, so marking this issue as a good first issue

@vincenzopalazzo vincenzopalazzo added good first issue good for onboarding and removed question labels Mar 12, 2024
@srikanth-iyengar
Copy link

Is this issue up for grabs ?

@DreadPirate07
Copy link

Hello, I was curious if this issue was up for grabs? If so, could you possibly assign this issue to me?

@vincenzopalazzo
Copy link
Collaborator

You can go with this issue without be assigned, just feel free to open a PR @srikanth-iyengar @DreadPirate07

@BitcoinJiuJitsu
Copy link

BitcoinJiuJitsu commented Mar 26, 2024 •
edited

@srikanth-iyengar @DreadPirate07 share a Sphinx Chat profile with Core Lightning and we can look to throw some bounty your way!

https://community.sphinx.chat/bounty/1747

@srikanth-iyengar
Copy link

That's interesting

@SETURAJ
Copy link

SETURAJ commented Apr 18, 2024

I would work upon this issue.
Can I get some more info regarding this issue?

@maxrantil maxrantil linked a pull request Apr 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good for onboarding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CLN service startup failure by trimming trailing spaces in config parameters maxrantil/lightning
6 participants
@vincenzopalazzo @SETURAJ @BTCBellyButton @srikanth-iyengar @BitcoinJiuJitsu @DreadPirate07