Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scrolling for scripting area in Elemental #250

Open
iamunknown2 opened this issue Apr 13, 2017 · 8 comments
Open

No scrolling for scripting area in Elemental #250

iamunknown2 opened this issue Apr 13, 2017 · 8 comments
Assignees

Comments

@iamunknown2
Copy link
Contributor

iamunknown2 commented Apr 13, 2017

See above (using Firefox 52 on Ubuntu Linux).

I think I can make a quick PR to fix this issue.

@mrjacobbloom
Copy link
Contributor

note: this is incompatible with tutorials

@iamunknown2
Copy link
Contributor Author

note: this is incompatible with tutorials

The only glitch I see is the topBar being pushed upwards in the tutorial for some reason. Is that what you're talking about?

If that's the case, this might be helpful.

@mrjacobbloom
Copy link
Contributor

That's the issue I'm talking about. If the window is small enough that you have the blocks area scrolled during the tutorial, the lightbox doesn't line up with the highlighted element anymore.

Also, after this PR, dragged blocks seem to be be behind the palette again (a la #216)

We might wanna roll back #251 and try again (preferably after #249 is merged)? @Firedrake969

@iamunknown2
Copy link
Contributor Author

Anyone got any idea why the glitch occurs? Is it because of intro.js?

@iamunknown2
Copy link
Contributor Author

It seems that the glitch occurs whenever the highlighting pane moves to the <div class="rightSide introjs-showElement introjs-relativePosition"> section of the page.

@mrjacobbloom
Copy link
Contributor

Intro.js just can't handle scrolled panes, I don't know anything beyond that... but we could probably modify the intro.js code to take element scroll position into account

@benajaero
Copy link

Why not put a container around it for introjs? Then introjs will just work on the container.

@benajaero
Copy link

Is this the same issue?
usablica/intro.js#210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants