Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 404 error pages design #170

Open
rumanti opened this issue Nov 21, 2015 · 34 comments
Open

Implement 404 error pages design #170

rumanti opened this issue Nov 21, 2015 · 34 comments

Comments

@rumanti
Copy link
Contributor

rumanti commented Nov 21, 2015

^

@PolyEdge
Copy link
Member

How do you do this in Heroku?

@matthewr6
Copy link
Contributor

http://stackoverflow.com/questions/1569682/how-to-create-a-custom-404-page-for-my-django-apache

(it might be better for you to think in terms of "in Django", not "in Heroku")
(also, unrelated, but you're just styling the ToS, right? not changing them?)

@PolyEdge
Copy link
Member

I don't know yet. Rumanti said that she needed help with both because of messy css. We have to discuss what's going to happen. My python client is nearly done, I separated it into classes of GitHub, User, AuthUser, Repository, AuthRepository, Organization, AuthOrganization, File, and AuthFile. I'll document it once it's finished. Before when I said I had it, all you could do was log in and edit files, you couldn't do Pull Requests or anything. My client can't create new branches or merge pull requests, although it can edit files in other repos. Ok??

@matthewr6
Copy link
Contributor

What's most needed is to clean up the CSS in the dev branch. I've marked a section that I've started working on that doesn't need cleanup. The more reusable a class in the CSS is, the better. You know how to sass --watch and have sass installed, right?

You should probably just learn the git CLI commands - might be easier that way ;)
Most of us are either using git or GitHub Desktop, and it's been working out pretty well.

For communication, we mostly use Gitter.
https://gitter.im/Firedrake969

@PolyEdge
Copy link
Member

Yeah, I noticed a few of the reusable classes like "raleway" --Pretty cool. Don't know sass 😦 I kind of can push from my python command line 😀 I got it working. I'm not going to share it until I have full support for repos and orgs-should be done soon. Here's a preview:

import GitHub
git = GitHub.GitHub('Dylan5797', 'thisisnotmypassword')
print(git.user.get_repositories()[0].name)
'Dylan5797/dylan5797.github.io'
f = AuthFile('Dylan5797/ScratchEdit:master/ScratchEdit.pyw', git)
f.edit('New content')
f.push()

pretty cool right! It might not turn out exactly as I put it here though.

@matthewr6
Copy link
Contributor

Go ahead and use of t, but try not to distract us 📦

@matthewr6
Copy link
Contributor

Use it* ugh mobile

@PolyEdge
Copy link
Member

Thanks! I will post it after I get orgs figured. I only have 200 lines but it works 😛

@PolyEdge
Copy link
Member

Maybe we can chat on gitter instead of an issue.

@matthewr6
Copy link
Contributor

So your first task is to clean up the SCSS. If you need help with SCSS feel free to ask.

@PolyEdge
Copy link
Member

In static folder? Any file in particular you want done first?

@matthewr6
Copy link
Contributor

style.scss

@PolyEdge
Copy link
Member

  • sections
  • uniformity
  • test
  • branch push

@matthewr6
Copy link
Contributor

uh
what

@PolyEdge
Copy link
Member

My checklist.

@matthewr6
Copy link
Contributor

For?

Also, just don't touch the .section and its nested rules - that's the part I've been working on.

@ghost
Copy link

ghost commented Nov 22, 2015

why not just use the <section> tag in html5??

@matthewr6
Copy link
Contributor

because
idk
I haven't gotten used to that super-semantic markup yet.

@ghost
Copy link

ghost commented Nov 22, 2015

k

@PolyEdge
Copy link
Member

PolyEdge commented Mar 2, 2016

This has gone a bit inactive. Is the design finished yet?

@matthewr6
Copy link
Contributor

@ElementalCode/programmers status?

@TheInitializer
Copy link

do we have a 404 design?

@matthewr6
Copy link
Contributor

idk, find one or make one

@matthewr6
Copy link
Contributor

@rumanti you still doing this?

@matthewr6 matthewr6 assigned PolyEdge and unassigned rumanti Mar 13, 2016
@TheInitializer
Copy link

codelet404
for inspiration, here's the 404 page of a code-sharing site I made a while back

@PolyEdge
Copy link
Member

http://codepen.io/Dylan5797/pen/GZpyVN

@matthewr6
Copy link
Contributor

I like it

@BookOwl
Copy link
Contributor

BookOwl commented Mar 14, 2016

Looks good!

@TheInitializer
Copy link

some sites have a searchbox on the 404 page, that might be a good idea. Searching is really easy to do in django

@matthewr6
Copy link
Contributor

@TheInitializer add that

@TheInitializer
Copy link

If I have time sure

@matthewr6
Copy link
Contributor

@Dylan5797 could you put the HTML file in the static root?

@PolyEdge
Copy link
Member

Oh my god I have commented like three times and it hasn't come through.

Yes, I'll add it.
I'm not dead, I was just without internet for a while.

@matthewr6
Copy link
Contributor

k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants