-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static versionCode & versionName instead of updated for each tag #4146
Comments
The static versions are meant to be updated by the build scripts. https://github.com/EdgeApp/edge-react-gui/blob/develop/scripts/deploy.ts is meant to create a production build and updates versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in AndroidManifest.xml file of generated APK that is locally built the versionCode is 21000000 and versionName is 99.99.99
cause of:
edge-react-gui/android/app/build.gradle
Lines 135 to 136 in 67e9597
while downloading APK from Google Play or Website will have values like:
versionCode: 23032902
versionName: 3.6.0
and it will be changed for each version.
static versionCode is problematic cause:
thus it make sense to update this value in repo to the correct one used in upcoming version before releasing new app, so for each git checkout of git tag, the values will be accurate for that version.
same apply for versionName to change it from 99.99.99 to the currently release like 3.6.0 and in every new git tag change it again
The text was updated successfully, but these errors were encountered: