Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static versionCode & versionName instead of updated for each tag #4146

Closed
emanuelb opened this issue Apr 21, 2023 · 1 comment
Closed

Static versionCode & versionName instead of updated for each tag #4146

emanuelb opened this issue Apr 21, 2023 · 1 comment

Comments

@emanuelb
Copy link

in AndroidManifest.xml file of generated APK that is locally built the versionCode is 21000000 and versionName is 99.99.99
cause of:

versionCode 21000000
versionName "99.99.99"

while downloading APK from Google Play or Website will have values like:

versionCode: 23032902
versionName: 3.6.0

and it will be changed for each version.

static versionCode is problematic cause:

  1. won't enable manual apk update of locally built apks (will need to remove apk and then install it again) as all built APKs will have the same version.
  2. fdroid will detect it as error and for workaround will use other assigned number for it that they manage unless it will be specified in the recipe which wont be automatic (but can be if values are updated in the repo and are accurate for each git tag)

thus it make sense to update this value in repo to the correct one used in upcoming version before releasing new app, so for each git checkout of git tag, the values will be accurate for that version.

same apply for versionName to change it from 99.99.99 to the currently release like 3.6.0 and in every new git tag change it again

@paullinator
Copy link
Member

The static versions are meant to be updated by the build scripts. https://github.com/EdgeApp/edge-react-gui/blob/develop/scripts/deploy.ts is meant to create a production build and updates versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants