removing impact warning messages #888
Conversation
…() to avoid warning messages of "unexpected handling on Initialization Action after repair".
| @@ -783,6 +784,11 @@ class EvaluatedIndividual<T>( | |||
| } | |||
| mutatedGenes.addedInitializationGenes.addAll(diff.flatMap { it.seeTopGenes() }) | |||
|
|
|||
| if (addedInsertions!!.flatten().isEmpty()) { | |||
There was a problem hiding this comment.
@man-zhang what would be the case of having ! diff.isEmpty() but then this if is true? ie, the diff is not empty, but addedInsertions is?
would that be a bug in EM?
There was a problem hiding this comment.
the difference might be due to db action repair.
here, we aim to keep consistency between genes and their impacts.
There was a problem hiding this comment.
Hi, @arcuri82
I cannot comment on the code which has been merged.
Please check the line 777,
val diff = individual.seeInitializingActions() .filter { !old.contains(it) && ((it is SqlAction && !it.representExistingData) || it is MongoDbAction) }
I am not sure whether the MongoDbAction should be always considered as diff.
Could you please have a check?
|
hi, @arcuri82 might need some discussion about impacts of MongoDb and DNS actions |
|
hi. @jgaleotti @man-zhang shall we have a meeting to discuss this? @man-zhang you are busy today. I m busy tomorrow (Thursday). Shall we have a meeting the 3 of us on Friday afternoon (Oslo time)? |
|
sound good to me! |
|
sounds good to me as well. it works for me before 3pm Oslo time. |
|
thx @man-zhang . @jgaleotti has created a meeting invitation |
…s' into log-impact-initialization-actions
|
@man-zhang can you take over this branch? and make sure MongoDB works fine with impact collection? |
# Conflicts: # core/src/main/kotlin/org/evomaster/core/problem/api/service/ApiWsStructureMutator.kt # core/src/main/kotlin/org/evomaster/core/search/EvaluatedIndividual.kt
|
Any updates on this PR? |
|
@jgaleotti hi. waiting for some more fixes in other branches before resuming work on this one. |
# Conflicts: # core/src/main/kotlin/org/evomaster/core/problem/rest/service/AbstractRestFitness.kt # e2e-tests/spring-rest-openapi-v2/src/test/java/org/evomaster/e2etests/spring/examples/wiremock/service/ExternalServiceMockingEMTest.java
|
thxs!
JP
… On 14 Jun 2024, at 7:55 AM, Andrea Arcuri ***@***.***> wrote:
Merged #888 <#888> into master.
—
Reply to this email directly, view it on GitHub <#888 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADTDTPUBKKTWXIYRO5S4B73ZHLDYJAVCNFSM6AAAAABCK3WN4CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGE2TSMZTGA3DKOA>.
You are receiving this because you were mentioned.
|
Adding logic to avoid "unexpected handling on Initialization Action after repair" when it is not necessary