Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ImpactX_ablastr_internal=OFF ? #634

Open
e-carlin opened this issue Jun 12, 2024 · 4 comments
Open

Support for ImpactX_ablastr_internal=OFF ? #634

e-carlin opened this issue Jun 12, 2024 · 4 comments
Assignees
Labels

Comments

@e-carlin
Copy link

In my environment I am trying to install both warpx and impactx. Both of them depend on ablastr which is built as part of each codes build process. This causes conflicts on install because both impactx and warpx try to install ${CMAKE_INSTALL_PREFIX}/lib/libablastr*.

It looks like impactx has the start of support for setting ImpactX_ablastr_internal=OFF but it currently errors out. If I could set this flag then I think I could have impactx use the ablastr library installed by warpx.

Would it be possible to make this flag work? If someone can give some direction on what is needed I'm happy to open a PR.

Thanks!

@ax3l
Copy link
Member

ax3l commented Jun 17, 2024

Hi @e-carlin,

Yes, that is a good point and on the todo list. For this, we first need to finalize the WarpXConfig.cmake* script, which is still in draft state: https://github.com/ECP-WarpX/WarpX/blob/development/WarpXConfig.cmake.

Ideally, inside WarpX, we will add two CMake options WarpX_INSTALL and ABLASTR_INSTALL (the 2nd is required if the former is set) to select the install logic.
Then we need to add support to find an external ABLASTR in both WarpX and ImpactX (easy).

@ax3l
Copy link
Member

ax3l commented Jun 18, 2024

Tracking in ECP-WarpX/WarpX#5002

@e-carlin
Copy link
Author

Thanks @ax3l! Let me know when there is a pr and I can test.

@ax3l
Copy link
Member

ax3l commented Jun 19, 2024

Draft started in ECP-WarpX/WarpX#5008 . Not yet ready for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants