Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Guidance on Modifying Parameter Name to Address Vulnerability Scan Concerns #1306

Open
tonyliving opened this issue Jun 26, 2024 · 2 comments

Comments

@tonyliving
Copy link

Which version of Duende IdentityServer are you using?
7.0
Which version of .NET are you using?
8.0

My client requested a third-party security company to conduct a vulnerability scan, which identified the EndSessionCallback request's endSessionId parameter as sensitive information leakage due to the inclusion of the keyword session. My client has limited knowledge about security and asked us to make modifications. Could you provide a method to rename this parameter or change it to static readonly? I am considering using reflection to modify it.

@RolandGuijt
Copy link

Can you please explain why the parameter name would be a problem?
It's hard to change because it's hardcoded into IdentityServer.

From my perspective the only part of the parameter that could be vulnerable is its value. And that is encrypted.

@RolandGuijt RolandGuijt self-assigned this Jun 28, 2024
@tonyliving
Copy link
Author

Just because of the name, mainly because the client does not understand security-related knowledge and only listens to reports from third-party security companies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants