Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in port selection #9

Open
AlphonsG opened this issue May 9, 2022 · 1 comment
Open

Bug in port selection #9

AlphonsG opened this issue May 9, 2022 · 1 comment

Comments

@AlphonsG
Copy link

AlphonsG commented May 9, 2022

There is now the option to select the port bind to in logger_tt, which especially useful if the default port (9020) is already bound to. However, if you choose port 0 in setup_logging(), which by default should let the OS choose a free port for you (wish is ideal), the conditional below:

self._port = odict.get('port') or handlers.DEFAULT_TCP_LOGGING_PORT

will result in the default port (9020) being selected again (0 or 9020 = 9020), and you are back to square one.

@AlphonsG
Copy link
Author

AlphonsG commented May 9, 2022

I have opened a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant