-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in RAR5 solid files #7
Comments
As an update of sorts, I haven't yet found an easy way to fix this. It looks like I'll need to take apart solid file support and redo it mostly from scratch. I was basing it on partially wrong assumptions. As a consequence, solid files are partially broken at the moment still. Partially meaning, it might work depending on the files that are bundled together in a solid chunk. Tiny files in particular are more prone to breaking. dmc_unrar isn't silently producing broken files, however, at least not as long as checksum validation is enabled. |
While testing for #4, I noticed a bug in our handling of RAR5 solid files. Sometimes, we produce broken output.
Example:
1.txt
blah
2.txt
foo
rar -ma5 -s a test.rar 1.txt 2.txt
This creates a solid RAR5 file we can't correctly decompress. The first file extracts fine, the second doesn't. Seems to be connected to our "finishing off" of the remaining of the solid block. I assume it produces output that belongs into the second file instead of just influencing the state?
The text was updated successfully, but these errors were encountered: