-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usernames are removed from accounts.aof with clean save #1637
Comments
I'm not sure we even should be writing usernames in the aof file. Usernames can be changed so that information will become invalid unless we also update it, which then defeats the purpose of it being a "append only" file |
I added them in to make ctrl+F'ing to find entries easier but I agree they're not really worth the hassle of maintaining |
Comments in the .aof file have been removed for consistencies sake. |
Expected behavior
When the accounts.aof file is rewritten due to >= 10% of lines being modifications, the comments containing the Discord and Minecraft usernames should remain.
Actual behavior
Only the identifiers are included in the new file contents, the comments are removed.
Steps to reproduce
Start the server with an accounts.aof file where 10% or more of the lines are modifications to cause the file to be rewritten.
Server software and version
No response
Checks
The text was updated successfully, but these errors were encountered: