hi, i'm porting DiscUtils to Java.
when i used SpotBugs, it pointed out 3 suspicious bugs.

1. RpC: Repeated conditional tests (RpC_REPEATED_CONDITIONAL_TEST)

The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0).

1. the index of _runs at the second condition might be i + 1, right ???

2. This method DiscUtils.Core.LogicalDiskManager.DynamicDisk.GetPrivateHeader(VirtualDisk) continues a loop after finding an equality condition

This method continues with a loop, and does not break out of it, after finding and setting a variable in an if condition based on equality. Since continuing on in the loop would seem to be unlikely to find the item again, breaking at this point would seem to be the proper action.

2. is this code intended?

3. This method DiscUtils.Core.Partitions.BiosExtendedPartitionTable.GetMetadataDiskExtents() continues a loop after finding an equality condition

Example:

int age = 0;
for (Person p : people) {
    if (p.getName().equals("Dave")) {
        age = p.getAge();
    }
}

It is likely you wanted a break after getting the age for "Dave".

3. is this code intended?

thanks,