Memory exhausted

[acharseth]

Hi!

I try to debug an issue using Tinker but then get an error message:

> $me=LdapUser::findBy('samaccountname','someUser');
PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in /var/www/html/puls/releases/39/vendor/directorytree/ldaprecord/src/Connection.php on line 279
PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in /var/www/html/puls/releases/39/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php on line 254

I get this error in my test environment, which uses MS AD. In development environment, using the emulator, I am not getting this error.

So we increased the allowed memory size from 128M to 512M but I still get the samme error message:

> $me=LdapUser::findBy('samaccountname','someUser');
PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted ...

Should this simple find cause this much memory consumption or do I have some kind of misconfiguration?

[acharseth]

Increased to 1024M but same result...

[acharseth]

Even php artisan ldap:test creates the same error message so something fundamental is wrong with the setup...

[stevebauman]

Hi @acharseth, it appears there's some kind of memory issue (likely something recursive going on) when an event is being fired on the connection (according to the first line of the exception):

https://github.com/DirectoryTree/LdapRecord/blob/1fa74d0cfdc88a7560476a98b10df6e24db6dd52/src/Connection.php#L273-L281

Do you have any custom connection event listeners bound?

[acharseth]

Yes, I have set up a listener, LdapCoreServiceProvider. This has been added to providers-list in config/app.php. It looks like this:

namespace App\Providers;

use Illuminate\Support\ServiceProvider;
use App\Services\LogType;
use App\Services\MyLog;
use LdapRecord\Models\ActiveDirectory\User as LdapUser;
use LdapRecord\Auth\Events\Attempting;
use LdapRecord\Auth\Events\Binding;
use LdapRecord\Auth\Events\Passed;
use LdapRecord\Auth\Events\Failed;
use LdapRecord\Auth\Events\Bound;

class LdapCoreServiceProvider extends ServiceProvider
{
    /**
     * Register services.
     */
    public function register(): void
    {
       $dispatcher = \LdapRecord\Container::getDispatcher();
       
       $dispatcher->listen(Attempting::class, function ($event) {    
           $userid=LdapUser::find($event->getUsername())->samaccountname[0]; 
           MyLog::uaUidLog(LogType::Info, get_class($event), $userid, "Ldap autentiseringsforsøk");
        });
       
       $dispatcher->listen(Binding::class, function ($event) {    
           $userid=LdapUser::find($event->getUsername())->samaccountname[0]; 
           MyLog::uaUidLog(LogType::Info, get_class($event), $userid, "Ldap binding");
        });
       
       $dispatcher->listen(Passed::class, function ($event) {    
           $userid=LdapUser::find($event->getUsername())->samaccountname[0]; 
           MyLog::uaUidLog(LogType::Info, get_class($event), $userid, "Ldap autentisert");
        });
       
       $dispatcher->listen(Failed::class, function ($event) {    
           $userid=LdapUser::find($event->getUsername())->samaccountname[0]; 
           MyLog::uaUidLog(LogType::Alert, get_class($event), $userid, "Ldap autentisering feilet!");
        });
       
       $dispatcher->listen(Bound::class, function ($event) {    
           $userid=LdapUser::find($event->getUsername())->samaccountname[0]; 
           MyLog::uaUidLog(LogType::Info, get_class($event), $userid, "Ldap bound");
        });    
    }

    /**
     * Bootstrap services.
     */
    public function boot(): void
    {
        //
    }
}

So maybe the LdapUser::find($event->getUsername())->samaccountname[0]; causes a loop?

[acharseth]

Yes, it does!
Is it possible to do a find without triggering a new event?

[acharseth]

May be you could include samaccountname in the Event making it possible to do a getSamaccountname(), @stevebauman ?

[stevebauman]

It's likely due to this listener here:

$dispatcher->listen(Binding::class, function ($event) {
   $userid=LdapUser::find($event->getUsername())->samaccountname[0];
   MyLog::uaUidLog(LogType::Info, get_class($event), $userid, "Ldap binding");
});

The Binding event is fired when a connection attempt is being made to the LDAP server. When you issue an LdapUser::find() inside of this listener, the connection is not bound yet, causing it to be connected to, which will generate this event again, causing a recursive loop.

May be you could include samaccountname in the Event making it possible to do a getSamaccountname(), @stevebauman ?

This isn't possible, because we haven't made a connection to the LDAP server yet in the Attempting and Binding events, so we cannot retrieve the binding user's samaccountname. Only the connection, username (the distinguishedname), and password is available in these events.