Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Form Names #44

Open
DiptoChakrabarty opened this issue Sep 30, 2021 · 7 comments
Open

Modify Form Names #44

DiptoChakrabarty opened this issue Sep 30, 2021 · 7 comments
Labels
backend good first issue Good for newcomers hacktoberfest hacktoberfest-accepted

Comments

@DiptoChakrabarty
Copy link
Owner

DiptoChakrabarty commented Sep 30, 2021 •
edited

Currently the applications forms are defined in resume/forms.py

It would be good if the form names are redefined to start with capital letters and ending with Form (eg UserExpForm)

The forms present are

  • RegistartionForm (Done)
  • LoginForm (Done)
  • PostingForm (Done)
  • UsereducationForm
  • UserexperienceForm
  • UserProjectsForm
  • ResumeBuilderForm
  • UserSkillsForm
  • UserAchievementForm
  • RequestResetForm
  • ResetPasswordForm

The forms can be modified to the above names and the areas where the forms are used in the routes also have to modified.

Please send PR for any one of the above mentioned forms , do not send PR for multiple forms at a time.
@princekushwaha
Copy link
Contributor

I want to work on this, please assign it to me.

@DiptoChakrabarty
Copy link
Owner Author

Sure @princekushwaha 👍 which form are you working on

@princekushwaha
Copy link
Contributor

I am working on RegistrationForm.

@princekushwaha princekushwaha mentioned this issue Sep 30, 2021
Merged
@princekushwaha
Copy link
Contributor

I am participating in Hacktoberfest, can I make more pull requests tomorrow?

@DiptoChakrabarty
Copy link
Owner Author

DiptoChakrabarty commented Sep 30, 2021 •
edited

I am participating in Hacktoberfest, can I make more pull requests tomorrow?

Ya sure , plzz do so what would you like to modify

@BIKRAM-SAHA
Copy link
Contributor

Hi, would love to work on this issue for the login and posting form. Please assign it to me.

@DiptoChakrabarty
Copy link
Owner Author

Sure go ahead @BIKRAM-SAHA

BIKRAM-SAHA added a commit to BIKRAM-SAHA/Resume-Generator that referenced this issue Oct 1, 2021
@BIKRAM-SAHA
solved DiptoChakrabarty#44 for LoginForm and PostingForm
095aebd
DiptoChakrabarty added a commit that referenced this issue Oct 1, 2021
@DiptoChakrabarty
Merge pull request #46 from BIKRAM-SAHA/development
710f77e 
solved #44 for LoginForm and PostingForm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend good first issue Good for newcomers hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DiptoChakrabarty @princekushwaha @BIKRAM-SAHA