-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Margin collapsing doesn't work for direct children of a root node #601
Labels
bug
Something isn't working
Comments
@thecodrr I may be wrong, but looking at this example again, I don't think that there should be any margin collapsing happening here. I believe your example is equivalent to the following HTML: <body>
<div style="width: 100px; height: 100px;">
<div style="width: 100px; height: 50px; margin-top: 10px;"></div>
<div style="width: 100px; height: 50px; margin-top: 10px;"></div>
</div>
</body>
Did you mean to set bottom margin on node1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
taffy
version563d5dc
Platform
Rust
What you did
What went wrong
When
Display::Block
is set for a root node, margin collapsing doesn't work for its direct children.Additional information
This is probably occuring due to this line:
taffy/src/compute/mod.rs
Line 48 in 563d5dc
The text was updated successfully, but these errors were encountered: