Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There needs to be a better release process #139

Open
wirehead opened this issue Aug 1, 2020 · 4 comments
Open

There needs to be a better release process #139

wirehead opened this issue Aug 1, 2020 · 4 comments

Comments

@wirehead
Copy link

wirehead commented Aug 1, 2020

I have to fab a second set of PCBs because of an issue that's already been fixed in this library.

The part in question is 10103594-0001LF. Bug #76 was filed in 2018 noting that the size and shape of the prongs was wrong. It was "fixed" in #126 a year later, but not really fixed.

I was trying to solder up a PCB and I discovered that the part wouldn't fit. Got out my micrometer, discover that it's a bit off. And then I see in the git log that the problem has been fixed and wonder why I'm not seeing the fixed footprint and that's because it's been "fixed" but whatever process you've got that copies things around the repository hasn't been run in 12 months.

It really sucks to have a bad batch of PCBs because of a bug that was almost fixed 10 months ago.

@jacky4566
Copy link

Did you import the fixed library to your kicad?
AFAIK there is no process to update your local library automatically. You need to manually copy this master to your library location.

I like to use Github desktop for automatically updating my Github libraries.

@wirehead
Copy link
Author

wirehead commented Aug 1, 2020

The problem here is that the fix is only in the src/ directory (which KiCad isn't configured to use if I follow the provided instructions) and never made it over to the digikey-footprints.pretty/ directory, not that I don't know how to use git.

@bombledmonk
Copy link
Collaborator

I apologize, this is my fault in not getting the CI stuff up and running. I'll see if I can't get this to updated and the CI stuff to work yet this week.

@bschwind
Copy link

I just got bit by this as well. I've since manually copied the footprint over from the src/ directory to digikey-footprints.pretty/ as @wirehead has done, but should a PR be opened to move everything over? I imagine it shouldn't be much more than a simple script to copy the footprints over, but maybe there's more to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants