Typofix and loading emulators on windows #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
Windows terminals (cmd, powershell, gitbash, etc.) all support the use of forwardslash (
/
), so allowing it in the path is acceptable.As such, I removed the check for forwardslashes in the path and just allowed it, which works on my machine running windows 10.
To preserve backslash functionality, the command still wraps the path in quotes.
Additionally, since
getEmulatorPath
was the same function asgetPath
with the additional handling for the aforementioned issue, I removed the function.I also made a typofix to the error message:
you Android emulators!
->your Android emulators!
and did some cleaning up here and there to keep things tidy.