Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typofix and loading emulators on windows #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

multimokia
Copy link

Fixes #39

Windows terminals (cmd, powershell, gitbash, etc.) all support the use of forwardslash (/), so allowing it in the path is acceptable.
As such, I removed the check for forwardslashes in the path and just allowed it, which works on my machine running windows 10.

To preserve backslash functionality, the command still wraps the path in quotes.
Additionally, since getEmulatorPath was the same function as getPath with the additional handling for the aforementioned issue, I removed the function.

I also made a typofix to the error message: you Android emulators! -> your Android emulators!
and did some cleaning up here and there to keep things tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something went wrong fetching you android emulators
1 participant