Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD From Zero to Hero first PR #19

Merged
merged 1 commit into from
May 23, 2022
Merged

ArgoCD From Zero to Hero first PR #19

merged 1 commit into from
May 23, 2022

Conversation

ppsite
Copy link
Contributor

@ppsite ppsite commented May 22, 2022

  1. 完成 README.MD 首稿撰写
  2. 梳理实验用到的 CRD 配置
  3. 本地实验环境验证

martinliu
martinliu approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@martinliu martinliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个教程基确实兑现了你的标题的目标了，很强大，很全面的教程，非常期待你的分享。下面有几个建议：

  1. 图片目录中好像有三幅图并没有使用到，是不是忘了插入这些配图了。
  2. 虽然很饱满，但是如果能在大家最容易出错的几个地方，讲讲常见错误就完美了。
  3. 篇幅比较长，可否在前面写一个初学者的建议，两句话说下，新手应该准备什么样的资源环境，然后就可以对着你这个教程操练了。中高级选手需要准备那些资源，才能完整打完你这套拳法。

@martinliu martinliu merged commit 42ce982 into DevopsChina:main May 23, 2022
@martinliu martinliu linked an issue May 24, 2022 that may be closed by this pull request
[ArgoCD] ArgoCD 核心知识点一稿通 #18
Open
@ppsite ppsite mentioned this pull request May 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinliu martinliu martinliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ArgoCD] ArgoCD 核心知识点一稿通
2 participants
@ppsite @martinliu