-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with the Subscribe/Unsubscribe function #7
Comments
This is due to narrowing issues in the language server LuaLS/lua-language-server#1456 If both static and non-static overloads are provided, then it wont correctly select between overloads taking The way I get around this is by only defining static or non-static subscribes depending on the class, despite most classes implementing both. Also the annotations shouldn’t always be static, most classes implement both a static and non-static version |
This works fine LuaLS/lua-language-server#1456 (comment) It breaks the doc popup though |
nanosworld-vscode/src/index.ts
Lines 231 to 246 in 0d4caa0
When adding the Subscribe/Unsubscribe functions to the annotations it should always be static. If you leave it with : it will give an error in the game but not in the IDE. So to fix it I think that lines 231-246 should be changed to this:
The text was updated successfully, but these errors were encountered: