Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples/serial22/ yaml format to work after refactoring merge #18

Closed
bergerch opened this issue Aug 30, 2022 · 2 comments
Closed

Update examples/serial22/ yaml format to work after refactoring merge #18

bergerch opened this issue Aug 30, 2022 · 2 comments
Assignees
@bentoumia
Labels
help wanted Extra attention is needed

Comments

@bergerch
Copy link
Contributor

Currently examples/serial22/ needs some modifications:

  • Update format to work after refactoring
  • Predefined plots can be removed from the hotstuff examples
@bergerch bergerch added the help wanted Extra attention is needed label Aug 30, 2022
@bergerch bergerch pinned this issue Aug 30, 2022
@bentoumia
Copy link
Contributor

bentoumia commented Aug 31, 2022 •
edited
Loading

EDFs Fixed. Sorry for the delay, i had to run sims for validation :D.

Will fix predefinedPlots today :)

@bentoumia
Copy link
Contributor

Fixed second point @bergerch see 287ae2e

users may now specify files with predefined datasets OR specify plots inline as it was done now:

ex: https://github.com/Delphi-BFT/tool/blob/main/examples/serial22/hs-p1024.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bentoumia bentoumia

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bergerch @bentoumia