-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm self-merge via 馃憤 reaction to bot comment #422
Comments
I'm not sure that this is a good idea... The reactions are less explicit, and mistaking them seems easier. Another point is that there are other reactions, some could mean an approval, and some a rejection. For example, if 馃憤 means "ready to merge", then I'd expect a 馃憥 to remove the self-merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Regarding the well-known bot message we all love:
I think it would be even nicer if PR creators only needed to give a 馃憤 reaction to the bot instead of writing a comment. Would this be possible or is the bot only triggered via new comments?
(Note to myself, the relevant lines of code appear to be here:
dt-mergebot/src/pr-info.ts
Lines 418 to 425 in 98d89b4
The text was updated successfully, but these errors were encountered: