-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requiring owner approval for critical-to-an-ecosystem types #248
Comments
cc @RyanCavanaugh, @orta. |
This is also important for types that do not have an associated npm package and thus no popularity level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Picking up a thread from this Discord discussion from about a month ago (!)—
Per @elibarzilay, the current bot system has a
danger
level and a popularity level, which combine to allow lower-popularity (non-"critical" or "popular") type definitions to be merged by any reviewer. While this makes a certain amount of sense, hinging on popularity means that type definitions which may be critical to a given audience can have changes slip through.As the motivating example, the types for
ember
,@ember/*
,ember-data
, and@ember-data/*
are critical to the experience of the entire Ember ecosystem—including JS users, courtesy of VS Code's automatic type acquisition. Ember is relatively low in popularity compared to e.g. React, but its core types still need owner review to be allowed through, because of their impact to the whole system.For our use case, it would be helpful to be able to mark that a given set of types always requires owner approval, regardless of popularity; or to otherwise simplify the rule sets in some way. We're fairly agnostic on the details of the solution; we just don't want random well-intentioned reviewers to accidentally get code merged!
cc. @dfreeman @jamescdavis
The text was updated successfully, but these errors were encountered: