[@types/better-sqlite3] SqliteError cannot be used as error type

[matjaeck]

import { SqliteError } from "better-sqlite3";

const uselessError = new SqliteError("foo", "bar");
const uselessCode = uselessError.code; // Works.

try {
  await dbQueryThatGoesBoom();
} catch (error) {
  // Oopsie, lets see what the error code tell us!
  // https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#class-sqliteerror

  // Nope. Property 'code' does not exist on type 'typeof SqliteError'.ts(2339).
  const veryImportantErrorCode = (error as typeof SqliteError).code;
}

This could be fixed by just removing the typeof operator here:

DefinitelyTyped/types/better-sqlite3/index.d.ts

Lines 86 to 100 in 778ad7a

	interface DatabaseConstructor {
	new(filename?: string | Buffer, options?: Database.Options): Database;
	(filename?: string, options?: Database.Options): Database;
	prototype: Database;
	SqliteError: typeof SqliteError;
	}
	}
	declare class SqliteError extends Error {
	name: string;
	message: string;
	code: string;
	constructor(message: string, code: string);
	}

However, this breaks the test here (why would you do that though?):

DefinitelyTyped/types/better-sqlite3/better-sqlite3-tests.ts

Line 4 in 778ad7a

const err = new Sqlite.SqliteError("ok", "ok");

How do you access SqliteError.code? It is there. Surely I am not the first person to check error codes from better-sqlite3. 💀

[typescript-bot]

Thanks for the discussion about "better-sqlite3", some useful links for everyone:

• npm
• DT
• Related discussions

Pinging the DT module owners: @Morfent, @matrumz, @sant123, @Loghorn, @andykais, @mrkstwrt, @stamerf, @beenotung.

[matjaeck]

Invalid, sorry.

if (error instanceof SqliteError) {
        const code = error.code; // Works
}