[oracledb] connectionAttributes is wrong for the password field (it is referencing pool instead of password) #69278
Unanswered
AndyNewmanCRIBL
asked this question in
Issues with a @types package
Replies: 3 comments
-
Thanks for the discussion about "oracledb", some useful links for everyone: Pinging the DT module owners: @connorjayfitzgerald, @dannyb648, @jacobwheale. |
Beta Was this translation helpful? Give feedback.
0 replies
-
it looks like password and pool had their descriptions swapped DefinitelyTyped/types/oracledb/index.d.ts Line 1385 in 8bb11a2 but then pool was removed, leaving the password field still with the pool description |
Beta Was this translation helpful? Give feedback.
0 replies
-
Fixed in #69379 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/oracledb/index.d.ts#L1742
line 1742
from an earlier commit, it should be
Beta Was this translation helpful? Give feedback.
All reactions