Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disk script #302

Closed
wants to merge 2 commits into from
Closed

add disk script #302

wants to merge 2 commits into from

Conversation

jxdv
Copy link
Contributor

@jxdv jxdv commented Jan 20, 2024

Closes #205.

@jxdv
Copy link
Contributor Author

jxdv commented Jan 22, 2024

Hi @christophetd, My GitHub account got suspended just few minutes after submitting this PR xD I think the automatic system got confused and thought that I might be writing the malicious code myself or whatever. Is there any change this and my other PRs will get reviewed in the near future?

christophetd
christophetd requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@christophetd christophetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original spirit of #205 was to detect a new behavior, namely when a Python script was written to disk and executed. I think this PR tries to match on a specific function name, which is quite different, so if you don't mind I think we can close this one

@christophetd christophetd self-assigned this Jan 22, 2024
@jxdv
Copy link
Contributor Author

jxdv commented Jan 22, 2024

The original spirit of #205 was to detect a new behavior, namely when a Python script was written to disk and executed. I think this PR tries to match on a specific function name, which is quite different, so if you don't mind I think we can close this one

Yes, I misunderstood that issue

@jxdv jxdv closed this Jan 22, 2024
@jxdv jxdv deleted the disk-script branch January 22, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophetd christophetd christophetd requested changes

Assignees

@christophetd christophetd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New heuristic to identify Python script written to disk and executed
2 participants
@jxdv @christophetd