Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Command 52 temperature deserialization (bit 6 secret ;-) #17

Open
pavelchuchma opened this issue Jul 18, 2023 · 1 comment
Open

Comments

@pavelchuchma
Copy link

Hi Danny,
your doc tells about temperature in Command 52:

bit 5-0 : set temperature - 9
bit 6 : always set to '1' ?

In reality it should be:

bit 6-0 : set temperature + 55

Detected & tested on my java HVAC Controller project during hot summer when AC air output was 8°C but original deserialization read it wrongly as 72°C.

Feel free to see this fix, especially the test method at the end.

@DannyDeGaspari
Copy link
Owner

Thanks for mentioning this ! I will update my docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants